Hi,
I recently discovered Fast Social Share and am very impressed with the speed!
Thanks very much for providing this for free!
I made some changes on my v2.0 copy so that the extension passes the W3C validator at
http://validator.w3.org and am sharing the changes here in case others find this useful.
Issue 1: W3C validator states: "Error: Attribute . not allowed on element div at this point."
There seems to be an extraneous period in the code in /plugins/content/fastsocialshare/fastsocialshare.php
Line 129:
Code: |
data-layout="' . $layout . '" .
|
Amended to:
Code: |
data-layout="' . $layout . '"
|
Issue 2: W3C validator states: "Element g
lusone not allowed as child of element div in this context."
Some code in /plugins/content/fastsocialshare/fastsocialshare.php needs to be updated to be valid under HTML 5.
Line 226:
Code: |
$type = 'size="' . $params->get("plusType", 'medium') . '"';
|
Amended to:
Code: |
$type = 'data-size="' . $params->get("plusType", 'medium') . '"';
|
Line 231:
Code: |
$plusButton = "<g:plusone annotation='$shareAnnotation' $type href='$url'></g:plusone>";
|
Amended to:
Code: |
$plusButton = "<div class='g-plusone' data-annotation='$shareAnnotation' $type data-href='$url'></div>";
|
Line 235:
Code: |
$gShareButton = "<g:plus annotation='$shareAnnotation' href='$url' action='share'></g:plus>";
|
Amended to:
Code: |
$gShareButton = "<g:plus data-annotation='$shareAnnotation' data-href='$url' data-action='share'></g:plus>";
|